lkml.org 
[lkml]   [2020]   [Dec]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH AUTOSEL 4.14 24/66] s390/dasd: Fix operational path inconsistency
    Date
    From: Jan Höppner <hoeppner@linux.ibm.com>

    [ Upstream commit 9e34c8ba91697cb7441805c36d92ab3e695df6e0 ]

    During online processing and setting up a DASD device, the configuration
    data for operational paths is read and validated two times
    (dasd_eckd_read_conf()). The first time to provide information that are
    necessary for the LCU setup. A second time after the LCU setup as a
    device might report different configuration data then.

    When the configuration setup for each operational path is being
    validated, an initial call to dasd_eckd_clear_conf_data() is issued.
    This call wipes all previously available configuration data and path
    information for each path.
    However, the operational path mask is not updated during this process.

    As a result, the stored operational path mask might no longer correspond
    to the operational paths mask reported by the CIO layer, as several
    paths might be gone between the two dasd_eckd_read_conf() calls.

    This inconsistency leads to more severe issues in later path handling
    changes. Fix this by removing the channel paths from the operational
    path mask during the dasd_eckd_clear_conf_data() call.

    Signed-off-by: Jan Höppner <hoeppner@linux.ibm.com>
    Signed-off-by: Stefan Haberland <sth@linux.ibm.com>
    Reviewed-by: Stefan Haberland <sth@linux.ibm.com>
    Reviewed-by: Cornelia Huck <cohuck@redhat.com>
    Signed-off-by: Jens Axboe <axboe@kernel.dk>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/s390/block/dasd_eckd.c | 1 +
    1 file changed, 1 insertion(+)

    diff --git a/drivers/s390/block/dasd_eckd.c b/drivers/s390/block/dasd_eckd.c
    index aa651403546ff..8769b90c49a30 100644
    --- a/drivers/s390/block/dasd_eckd.c
    +++ b/drivers/s390/block/dasd_eckd.c
    @@ -979,6 +979,7 @@ static void dasd_eckd_clear_conf_data(struct dasd_device *device)
    device->path[i].cssid = 0;
    device->path[i].ssid = 0;
    device->path[i].chpid = 0;
    + dasd_path_notoper(device, i);
    }
    }

    --
    2.27.0
    \
     
     \ /
      Last update: 2020-12-23 03:42    [W:4.406 / U:1.068 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site