lkml.org 
[lkml]   [2020]   [Dec]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [RFC 15/18] mfd: max77693: Do not enforce (incorrect) interrupt trigger type
    On Thu, 10 Dec 2020 22:25:31 +0100, Krzysztof Kozlowski wrote:
    > Interrupt line can be configured on different hardware in different way,
    > even inverted. Therefore driver should not enforce specific trigger
    > type - edge falling - but instead rely on Devicetree to configure it.
    >
    > The Maxim 77693 datasheet describes the interrupt line as active low
    > with a requirement of acknowledge from the CPU therefore the edge
    > falling is not correct.
    >
    > The interrupt line is shared between PMIC and RTC driver, so using level
    > sensitive interrupt is here especially important to avoid races. With
    > an edge configuration in case if first PMIC signals interrupt followed
    > shortly after by the RTC, the interrupt might not be yet cleared/acked
    > thus the second one would not be noticed.
    >
    > Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
    >
    > ---
    >
    > This patch should wait till DTS changes are merged, as it relies on
    > proper Devicetree.
    > ---
    > Documentation/devicetree/bindings/mfd/max77693.txt | 2 +-
    > drivers/mfd/max77693.c | 12 ++++--------
    > 2 files changed, 5 insertions(+), 9 deletions(-)
    >

    Acked-by: Rob Herring <robh@kernel.org>

    \
     
     \ /
      Last update: 2020-12-21 19:49    [W:5.403 / U:0.060 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site