Messages in this thread | | | From | Miklos Szeredi <> | Date | Wed, 2 Dec 2020 17:18:43 +0100 | Subject | Re: [PATCH V2] uapi: fix statx attribute value overlap for DAX & MOUNT_ROOT |
| |
On Wed, Dec 2, 2020 at 5:03 PM Ira Weiny <ira.weiny@intel.com> wrote: > > On Tue, Dec 01, 2020 at 05:21:40PM -0600, Eric Sandeen wrote: > > [*] Note: This needs to be merged as soon as possible as it's introducing an incompatible UAPI change... > > > > STATX_ATTR_MOUNT_ROOT and STATX_ATTR_DAX got merged with the same value, > > so one of them needs fixing. Move STATX_ATTR_DAX. > > > > While we're in here, clarify the value-matching scheme for some of the > > attributes, and explain why the value for DAX does not match. > > > > Fixes: 80340fe3605c ("statx: add mount_root") > > Fixes: 712b2698e4c0 ("fs/stat: Define DAX statx attribute") > > Reported-by: David Howells <dhowells@redhat.com> > > Signed-off-by: Eric Sandeen <sandeen@redhat.com> > > Reviewed-by: David Howells <dhowells@redhat.com> > > Reviewed-by: Ira Weiny <ira.weiny@intel.com>
Stable cc also?
Cc: <stable@vger.kernel.org> # 5.8
Thanks, Miklos
| |