lkml.org 
[lkml]   [2020]   [Dec]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 2/2] platform/x86/drivers/acerhdf: Check the interval value when it is set
2. Dezember 2020 23:22, "Daniel Lezcano" <daniel.lezcano@linaro.org> schrieb:

> Currently the code checks the interval value when the temperature is
> read which is bad for two reasons:
>
> - checking and setting the interval in the get_temp callback is
> inaccurate and awful, that can be done when changing the value.
>
> - Changing the thermal zone structure internals is an abuse of the
> exported structure, moreover no lock is taken here.
>
> The goal of this patch is to solve the first item by using the 'set'
> function called when changing the interval. The check is done there
> and removed from the get_temp function. If the thermal zone was not
> initialized yet, the interval is not updated in this case as that will
> happen in the init function when registering the thermal zone device.
>
> I don't have any hardware to test the changes.

Thanks for this patch, I'll test it in upcoming days.

\
 
 \ /
  Last update: 2020-12-02 23:44    [W:0.083 / U:0.380 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site