lkml.org 
[lkml]   [2020]   [Dec]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 08/10] arm64: dts: imx8mm: Add Engicam i.Core MX8M Mini C.TOUCH 2.0
    On Wed, Dec 02, 2020 at 05:42:39PM +0530, Jagan Teki wrote:
    > i.Core MX8M Mini is an EDIMM SOM based on NXP i.MX8MM from Engicam.
    >
    > C.TOUCH 2.0 is a general purpose carrier board with capacitive
    > touch interface support.
    >
    > i.Core MX8M Mini needs to mount on top of this Carrier board for
    > creating complete i.Core MX8M Mini C.TOUCH 2.0 board.
    >
    > Add support for it.
    >
    > Signed-off-by: Matteo Lisi <matteo.lisi@engicam.com>
    > Signed-off-by: Jagan Teki <jagan@amarulasolutions.com>
    > ---
    > arch/arm64/boot/dts/freescale/Makefile | 1 +
    > .../imx8mm-engicam-icore-mx8mm-ctouch2.dts | 21 +++++++++++++++++++
    > 2 files changed, 22 insertions(+)
    > create mode 100644 arch/arm64/boot/dts/freescale/imx8mm-engicam-icore-mx8mm-ctouch2.dts
    >
    > diff --git a/arch/arm64/boot/dts/freescale/Makefile b/arch/arm64/boot/dts/freescale/Makefile
    > index 4369d783dade..8191db4c64fa 100644
    > --- a/arch/arm64/boot/dts/freescale/Makefile
    > +++ b/arch/arm64/boot/dts/freescale/Makefile
    > @@ -30,6 +30,7 @@ dtb-$(CONFIG_ARCH_LAYERSCAPE) += fsl-lx2160a-rdb.dtb
    > dtb-$(CONFIG_ARCH_LAYERSCAPE) += fsl-lx2162a-qds.dtb
    >
    > dtb-$(CONFIG_ARCH_MXC) += imx8mm-beacon-kit.dtb
    > +dtb-$(CONFIG_ARCH_MXC) += imx8mm-engicam-icore-mx8mm-ctouch2.dtb
    > dtb-$(CONFIG_ARCH_MXC) += imx8mm-engicam-icore-mx8mm-edimm2.2.dtb
    > dtb-$(CONFIG_ARCH_MXC) += imx8mm-evk.dtb
    > dtb-$(CONFIG_ARCH_MXC) += imx8mm-ddr4-evk.dtb
    > diff --git a/arch/arm64/boot/dts/freescale/imx8mm-engicam-icore-mx8mm-ctouch2.dts b/arch/arm64/boot/dts/freescale/imx8mm-engicam-icore-mx8mm-ctouch2.dts
    > new file mode 100644
    > index 000000000000..aa3c03ad3109
    > --- /dev/null
    > +++ b/arch/arm64/boot/dts/freescale/imx8mm-engicam-icore-mx8mm-ctouch2.dts
    > @@ -0,0 +1,21 @@
    > +// SPDX-License-Identifier: (GPL-2.0+ OR MIT)
    > +/*
    > + * Copyright (c) 2019 NXP
    > + * Copyright (c) 2019 Engicam srl
    > + * Copyright (c) 2020 Amarula Solutions(India)
    > + */
    > +
    > +/dts-v1/;
    > +#include "imx8mm.dtsi"

    You have multiple DTSI files to only include one DTSI. I was trying to
    follow the logic here but I failed...

    This is ctouch, so it should include SoM, which you call icore. But it
    also includes ctouch2 which *only* includes common DTSI. It's then
    exactly the same as starter kit which includes edimm (which includes
    common) and icore.

    Best regards,
    Krzysztof


    > +#include "imx8mm-engicam-ctouch2.dtsi"
    > +#include "imx8mm-engicam-icore-mx8mm.dtsi"
    > +
    > +/ {

    \
     
     \ /
      Last update: 2020-12-02 18:47    [W:4.958 / U:0.068 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site