Messages in this thread | | | From | Yoshihiro Shimoda <> | Subject | RE: [PATCH v3 12/12] mfd: bd9571mwv: Add support for BD9574MWF | Date | Thu, 17 Dec 2020 11:44:25 +0000 |
| |
Hi Lee,
Thank you for your review!
> From: Lee Jones, Sent: Thursday, December 17, 2020 12:38 AM > > On Wed, 16 Dec 2020, Yoshihiro Shimoda wrote: > > > From: Khiem Nguyen <khiem.nguyen.xt@renesas.com> > > > > The new PMIC BD9574MWF inherits features from BD9571MWV. > > Add the support of new PMIC to existing bd9571mwv driver. > > > > Signed-off-by: Khiem Nguyen <khiem.nguyen.xt@renesas.com> > > [shimoda: rebase and refactor] > > Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com> > > --- > > drivers/mfd/bd9571mwv.c | 86 ++++++++++++++++++++++++++++++++++++++++++- > > include/linux/mfd/bd9571mwv.h | 18 +++++++-- > > 2 files changed, 99 insertions(+), 5 deletions(-) > > > > diff --git a/drivers/mfd/bd9571mwv.c b/drivers/mfd/bd9571mwv.c > > index ccf1a60..f660de6 100644 > > --- a/drivers/mfd/bd9571mwv.c > > +++ b/drivers/mfd/bd9571mwv.c > > @@ -1,6 +1,6 @@ > > // SPDX-License-Identifier: GPL-2.0-only > > /* > > - * ROHM BD9571MWV-M MFD driver > > + * ROHM BD9571MWV-M and BD9574MVF-M MFD driver > > While you're at it, please remove "MFD". > > Maybe replace with 'core' or something?
I got it. I'll replace with 'core'.
> > * Copyright (C) 2017 Marek Vasut <marek.vasut+renesas@gmail.com> > > * Copyright (C) 2020 Renesas Electronics Corporation > > @@ -11,6 +11,7 @@ > > #include <linux/i2c.h> > > #include <linux/interrupt.h> > > #include <linux/mfd/core.h> > > +#include <linux/mfd/rohm-generic.h> > > #include <linux/module.h> > > > > #include <linux/mfd/bd9571mwv.h> > > @@ -28,6 +29,7 @@ struct bd957x_data { > > int num_cells; > > }; > > > > +/* For BD9571MWV */ > > Don't think this is required?
I'll remove it.
Best regards, Yoshihiro Shimoda
| |