lkml.org 
[lkml]   [2020]   [Dec]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH v2 05/11] perf c2c: Refactor hist entry validation
    Date
    This patch has no any functionality changes but refactors hist entry
    validation for cache line resorting.

    It renames function "valid_hitm_or_store()" to "is_valid_hist_entry()",
    changes return type from integer type to bool type. In the function,
    it uses switch-case instead of ternary operators, which is easier
    to extend for more display types.

    Signed-off-by: Leo Yan <leo.yan@linaro.org>
    ---
    tools/perf/builtin-c2c.c | 30 +++++++++++++++++++++++-------
    1 file changed, 23 insertions(+), 7 deletions(-)

    diff --git a/tools/perf/builtin-c2c.c b/tools/perf/builtin-c2c.c
    index 580c4ead68db..5cd30c083d6c 100644
    --- a/tools/perf/builtin-c2c.c
    +++ b/tools/perf/builtin-c2c.c
    @@ -2178,16 +2178,32 @@ static bool he__display(struct hist_entry *he, struct c2c_stats *stats)
    return he->filtered == 0;
    }

    -static inline int valid_hitm_or_store(struct hist_entry *he)
    +static inline bool is_valid_hist_entry(struct hist_entry *he)
    {
    struct c2c_hist_entry *c2c_he;
    - bool has_hitm;
    + bool has_record = false;

    c2c_he = container_of(he, struct c2c_hist_entry, he);
    - has_hitm = c2c.display == DISPLAY_TOT ? c2c_he->stats.tot_hitm :
    - c2c.display == DISPLAY_LCL ? c2c_he->stats.lcl_hitm :
    - c2c_he->stats.rmt_hitm;
    - return has_hitm || c2c_he->stats.store;
    +
    + /* It's a valid entry if contains stores */
    + if (c2c_he->stats.store)
    + return true;
    +
    + switch (c2c.display) {
    + case DISPLAY_LCL:
    + has_record = !!c2c_he->stats.lcl_hitm;
    + break;
    + case DISPLAY_RMT:
    + has_record = !!c2c_he->stats.rmt_hitm;
    + break;
    + case DISPLAY_TOT:
    + has_record = !!c2c_he->stats.tot_hitm;
    + break;
    + default:
    + break;
    + }
    +
    + return has_record;
    }

    static void set_node_width(struct c2c_hist_entry *c2c_he, int len)
    @@ -2241,7 +2257,7 @@ static int filter_cb(struct hist_entry *he, void *arg __maybe_unused)

    calc_width(c2c_he);

    - if (!valid_hitm_or_store(he))
    + if (!is_valid_hist_entry(he))
    he->filtered = HIST_FILTER__C2C;

    return 0;
    --
    2.17.1
    \
     
     \ /
      Last update: 2020-12-13 14:43    [W:4.195 / U:3.424 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site