lkml.org 
[lkml]   [2020]   [Dec]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [RFC 18/18] power: supply: max17040: Do not enforce (incorrect) interrupt trigger type
On Thu, Dec 10, 2020 at 11:16:00PM +0100, Sebastian Reichel wrote:
> (I shortened the Cc)
>
> Hi,
>
> On Thu, Dec 10, 2020 at 10:25:34PM +0100, Krzysztof Kozlowski wrote:
> > [...]
> > index d956c67d5155..f737de0470de 100644
> > --- a/drivers/power/supply/max17040_battery.c
> > +++ b/drivers/power/supply/max17040_battery.c
> > @@ -367,7 +367,7 @@ static int max17040_enable_alert_irq(struct max17040_chip *chip)
> >
> > flags = IRQF_TRIGGER_FALLING | IRQF_ONESHOT;
> > ret = devm_request_threaded_irq(&client->dev, client->irq, NULL,
> > - max17040_thread_handler, flags,
> > + max17040_thread_handler, IRQF_ONESHOT,
> > chip->battery->desc->name, chip);
> >
> > return ret;
>
> 'flags' is unused after this change.

Indeed, thanks. Kbuild also complained now on my github branch. I'll fix
it in v2.

\
 
 \ /
  Last update: 2020-12-11 08:54    [W:0.151 / U:0.096 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site