lkml.org 
[lkml]   [2020]   [Dec]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    Date
    SubjectRe: [patch 03/30] genirq: Move irq_set_lockdep_class() to core
    On Thu, Dec 10, 2020 at 10:14 PM Thomas Gleixner <tglx@linutronix.de> wrote:
    >
    > irq_set_lockdep_class() is used from modules and requires irq_to_desc() to
    > be exported. Move it into the core code which lifts another requirement for
    > the export.

    ...

    > + if (IS_ENABLED(CONFIG_LOCKDEP))
    > + __irq_set_lockdep_class(irq, lock_class, request_class);

    Maybe I missed something, but even if the compiler does not warn the
    use of if IS_ENABLED() with complimentary #ifdef seems inconsistent.

    > +#ifdef CONFIG_LOCKDEP
    ...
    > +EXPORT_SYMBOL_GPL(irq_set_lockdep_class);
    > +#endif


    --
    With Best Regards,
    Andy Shevchenko

    \
     
     \ /
      Last update: 2020-12-11 19:00    [W:2.335 / U:0.420 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site