lkml.org 
[lkml]   [2020]   [Dec]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: bikeshed: [PATCH -next] mfd: rave-sp: convert comma to semicolon
On Fri, 11 Dec 2020, David Laight wrote:

> From: Lee Jones
> > Sent: 11 December 2020 13:11
> ...
> > > Nowt wrong with commas.
> >
> > Well you learn something new every day!
> >
> > > Why not go the other way.
> > > Convert almost all the ; to , and delete most of the { } in
> > > if and for statements (etc).
> >
> > Sorry, I don't understand. Please elaborate/provide an example.
>
> You can (largely) replace:
> if (...) {
> xxx;
> yyy;
> }
> zzz;
> With
> if (...)
> xxx,
> yyy;
> zzz;
>
> Saves a vertical line....
> You may need to replace some 'if' by ?: to avoid the terminating ;

No, please don't do any of that.

The current patch is fine.

--
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog

\
 
 \ /
  Last update: 2020-12-11 15:49    [from the cache]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and my Meterkast|Read the blog