Messages in this thread | | | Date | Thu, 10 Dec 2020 13:58:00 +0100 | From | Uwe Kleine-König <> | Subject | Re: [PATCH v4] pwm: bcm2835: Support apply function for atomic configuration |
| |
On Wed, Dec 09, 2020 at 09:48:25PM +0100, Lino Sanfilippo wrote: > Use the newer .apply function of pwm_ops instead of .config, .enable, > .disable and .set_polarity. This guarantees atomic changes of the pwm > controller configuration. It also reduces the size of the driver. > > Since now period is a 64 bit value, add an extra check to reject periods > that exceed the possible max value for the 32 bit register. > > This has been tested on a Raspberry PI 4. > > Signed-off-by: Lino Sanfilippo <LinoSanfilippo@gmx.de>
I replied to v3 earlier, this was supposed to go to this v4 of course. Still had v3 open for comparing the two. So to ensure it is picked up:
Reviewed-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Best regards Uwe
-- Pengutronix e.K. | Uwe Kleine-König | Industrial Linux Solutions | https://www.pengutronix.de/ | [unhandled content-type:application/pgp-signature] | |