lkml.org 
[lkml]   [2020]   [Dec]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] Input: edt-ft5x06 - consolidate handling of number of electrodes
On Thu, Dec 10, 2020 at 11:08:03AM +0100, Marco Felsch wrote:
> On 20-12-09 15:09, Dmitry Torokhov wrote:

...

> > case EV_FT:
> > reg_addr->reg_threshold = EV_REGISTER_THRESHOLD;
> > + reg_addr->reg_report_rate = NO_REGISTER;
> > reg_addr->reg_gain = EV_REGISTER_GAIN;
> > reg_addr->reg_offset = NO_REGISTER;
> > reg_addr->reg_offset_x = EV_REGISTER_OFFSET_X;
> > reg_addr->reg_offset_y = EV_REGISTER_OFFSET_Y;
> > reg_addr->reg_num_x = NO_REGISTER;
> > reg_addr->reg_num_y = NO_REGISTER;
> > - reg_addr->reg_report_rate = NO_REGISTER;
> > break;
>
> Nit:
> Unrelated change.

I guess the motive is to get these assignments consistent between the cases.
Documentation actually allows this kind of modifications of code in one change
when them are toughly related.

--
With Best Regards,
Andy Shevchenko


\
 
 \ /
  Last update: 2020-12-10 12:37    [W:0.064 / U:3.468 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site