lkml.org 
[lkml]   [2020]   [Dec]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] mmc: sdhci-msm: Warn about overclocking SD/MMC
From
Date
Quoting Doug Anderson (2020-12-10 13:20:03)
> On Thu, Dec 10, 2020 at 1:03 PM Stephen Boyd <swboyd@chromium.org> wrote:
> >
> >
> > Can we use dev_warn?
>
> What's here matches other prints including other ones in the same
> function and in much of the MMC subsystem. mmc_hostname() shows
> "mmc1"
>
> > dev_warn(mmc_dev(mmc)
> > dev_warn(&msm_host->pdev->dev
>
> This show "sdhci_msm 7c4000.sdhci"
>
> I'm going to keep with tradition and keep using mmc_hostname(). In
> some parts of this file they use both (a dev_warn that also includes
> the mmc_hostname()) but that feels overkill.

Ok. This driver should be cleaned up I suppose.

\
 
 \ /
  Last update: 2020-12-10 22:29    [W:0.043 / U:0.576 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site