Messages in this thread | | | From | Muchun Song <> | Date | Fri, 11 Dec 2020 01:05:57 +0800 | Subject | Re: [External] Re: [RESEND PATCH v2 02/12] mm: memcontrol: convert NR_ANON_THPS account to pages |
| |
On Fri, Dec 11, 2020 at 12:12 AM Johannes Weiner <hannes@cmpxchg.org> wrote: > > On Sun, Dec 06, 2020 at 06:14:41PM +0800, Muchun Song wrote: > > @@ -1144,7 +1144,8 @@ void do_page_add_anon_rmap(struct page *page, > > * disabled. > > */ > > if (compound) > > - __inc_lruvec_page_state(page, NR_ANON_THPS); > > + __mod_lruvec_page_state(page, NR_ANON_THPS, > > + HPAGE_PMD_NR); > > __mod_lruvec_page_state(page, NR_ANON_MAPPED, nr); > > What I mistakenly wrote about the previous patch applies to this and > the following patches, though: > > /proc/vmstat currently prints number of anon, file and shmem THPs; you > are changing it to print number of 4k pages in those THPs. > > That's an ABI change we cannot really do.
Agree. Sorry. I forgot to fix the /proc/vmstat. Thanks for your reminder.
-- Yours, Muchun
| |