[lkml]   [2020]   [Dec]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH v5] drm/bridge: add it6505 driver
Hi Allen.
On Tue, Dec 01, 2020 at 01:44:41PM +0800, allen wrote:
> This adds support for the iTE IT6505.
> This device can convert DPI signal to DP output.
> From: Allen Chen <>
> Signed-off-by: Jitao Shi <>
> Signed-off-by: Pi-Hsun Shih <>
> Signed-off-by: Yilun Lin <>
> Signed-off-by: Hermes Wu <>
> Signed-off-by: Allen Chen <>

I recall I provided the same comment as last time, but may remember

New bridge drivers shall support that connector creation is optional.
This driver does not do that - see following code snippet:

+ DRM_ERROR("Fix bridge driver to make connector optional!");
+ return -EINVAL;
+ }

I did not check, but likely the drive needs to implment some of the
connector hooks too. (detect, get_edid, etc).

Please include a changelog too - it can be very hard to remember what
feedback was provided when one reviews several patches/week.


 \ /
  Last update: 2020-12-01 11:03    [W:0.120 / U:0.216 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site