Messages in this thread | | | Date | Tue, 1 Dec 2020 10:59:30 +0100 | From | Sam Ravnborg <> | Subject | Re: [PATCH v5] drm/bridge: add it6505 driver |
| |
Hi Allen. On Tue, Dec 01, 2020 at 01:44:41PM +0800, allen wrote: > This adds support for the iTE IT6505. > This device can convert DPI signal to DP output. > > From: Allen Chen <allen.chen@ite.com.tw> > Signed-off-by: Jitao Shi <jitao.shi@mediatek.com> > Signed-off-by: Pi-Hsun Shih <pihsun@chromium.org> > Signed-off-by: Yilun Lin <yllin@google.com> > Signed-off-by: Hermes Wu <hermes.wu@ite.com.tw> > Signed-off-by: Allen Chen <allen.chen@ite.com.tw>
I recall I provided the same comment as last time, but may remember wrong.
New bridge drivers shall support that connector creation is optional. This driver does not do that - see following code snippet:
+ if (flags & DRM_BRIDGE_ATTACH_NO_CONNECTOR) { + DRM_ERROR("Fix bridge driver to make connector optional!"); + return -EINVAL; + } +
I did not check, but likely the drive needs to implment some of the connector hooks too. (detect, get_edid, etc).
Please include a changelog too - it can be very hard to remember what feedback was provided when one reviews several patches/week.
Sam
| |