lkml.org 
[lkml]   [2020]   [Dec]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.9 146/152] usb: gadget: Fix memleak in gadgetfs_fill_super
    Date
    From: Zhang Qilong <zhangqilong3@huawei.com>

    commit 87bed3d7d26c974948a3d6e7176f304b2d41272b upstream.

    usb_get_gadget_udc_name will alloc memory for CHIP
    in "Enomem" branch. we should free it before error
    returns to prevent memleak.

    Fixes: 175f712119c57 ("usb: gadget: provide interface for legacy gadgets to get UDC name")
    Reported-by: Hulk Robot <hulkci@huawei.com>
    Acked-by: Alan Stern <stern@rowland.harvard.edu>
    Signed-off-by: Zhang Qilong <zhangqilong3@huawei.com>
    Link: https://lore.kernel.org/r/20201117021629.1470544-3-zhangqilong3@huawei.com
    Cc: stable <stable@vger.kernel.org>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

    ---
    drivers/usb/gadget/legacy/inode.c | 3 +++
    1 file changed, 3 insertions(+)

    --- a/drivers/usb/gadget/legacy/inode.c
    +++ b/drivers/usb/gadget/legacy/inode.c
    @@ -2039,6 +2039,9 @@ gadgetfs_fill_super (struct super_block
    return 0;

    Enomem:
    + kfree(CHIP);
    + CHIP = NULL;
    +
    return -ENOMEM;
    }


    \
     
     \ /
      Last update: 2020-12-01 10:41    [W:3.427 / U:0.144 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site