lkml.org 
[lkml]   [2020]   [Dec]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.9 13/42] HID: hid-sensor-hub: Fix issue with devices with no report ID
    Date
    From: Pablo Ceballos <pceballos@google.com>

    [ Upstream commit 34a9fa2025d9d3177c99351c7aaf256c5f50691f ]

    Some HID devices don't use a report ID because they only have a single
    report. In those cases, the report ID in struct hid_report will be zero
    and the data for the report will start at the first byte, so don't skip
    over the first byte.

    Signed-off-by: Pablo Ceballos <pceballos@google.com>
    Acked-by: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
    Signed-off-by: Jiri Kosina <jkosina@suse.cz>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/hid/hid-sensor-hub.c | 3 ++-
    1 file changed, 2 insertions(+), 1 deletion(-)

    diff --git a/drivers/hid/hid-sensor-hub.c b/drivers/hid/hid-sensor-hub.c
    index 4ef73374a8f98..7001f07ca3996 100644
    --- a/drivers/hid/hid-sensor-hub.c
    +++ b/drivers/hid/hid-sensor-hub.c
    @@ -489,7 +489,8 @@ static int sensor_hub_raw_event(struct hid_device *hdev,
    return 1;

    ptr = raw_data;
    - ptr++; /* Skip report id */
    + if (report->id)
    + ptr++; /* Skip report id */

    spin_lock_irqsave(&pdata->lock, flags);

    --
    2.27.0


    \
     
     \ /
      Last update: 2020-12-01 10:10    [W:2.629 / U:0.236 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site