lkml.org 
[lkml]   [2020]   [Dec]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v9 0/8] Carry forward IMA measurement log on kexec on ARM64
From
Date
On 12/1/20 11:15 AM, Mimi Zohar wrote:
> On Tue, 2020-12-01 at 11:10 -0800, Lakshmi Ramasubramanian wrote:
>> On 12/1/20 3:34 AM, Mimi Zohar wrote:
>>> On Sat, 2020-11-21 at 06:38 -0800, Lakshmi Ramasubramanian wrote:
>>>> On 11/21/20 5:57 AM, Rob Herring wrote:
>>>>> On Fri, Nov 13, 2020 at 11:22:35AM -0800, Lakshmi Ramasubramanian wrote:
>>>
>>>>>> arch/powerpc/include/asm/kexec.h | 1 -
>>>>>> arch/powerpc/kexec/Makefile | 7 +-
>>>>>> arch/powerpc/kexec/file_load.c | 32 --------
>>>>>> arch/powerpc/kexec/ima.c | 106 ++-----------------------
>>>>>> drivers/of/Makefile | 9 +++
>>>>>
>>>>>> drivers/of/ima_kexec.c | 91 +++++++++++++++++++++
>>>>>> drivers/of/kexec_fdt.c | 55 +++++++++++++
>>>>>
>>>>> Does this need to be 2 files? Just kexec.c?
>>>>
>>>> Since the functions defined in "ima_kexec.c" and "kexec_fdt.c" are
>>>> enabled on 2 different kernel CONFIGs, keeping them in 2 files enables
>>>> us to avoid using "#ifdef" in C files.
>>>
>>> Normally that is true, but just as all of the kexec related functions
>>> are co-located in ima/ima_kexec.c, co-locating all of the kexec related
>>> functions in drivers/of makes sense.
>>>
>>
>> Sounds good - i'll make the change.
>> Instead of "#ifdef" will use "IS_ENABLED" macro, and define the kexec
>> related functions in drivers/of/ima_kexec.c
>
> Perhaps name the file kexec.c, as Rob suggested.
>

Will do.

thanks,
-lakshmi


\
 
 \ /
  Last update: 2020-12-02 03:27    [W:0.097 / U:3.888 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site