lkml.org 
[lkml]   [2020]   [Dec]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 1/5] tty: add port flag to suppress ready signalling on open
On Tue, Dec 01, 2020 at 06:49:07AM +0100, Jiri Slaby wrote:
> On 30. 11. 20, 16:37, Johan Hovold wrote:
> > --- a/include/linux/tty.h
> > +++ b/include/linux/tty.h
> > @@ -683,6 +684,19 @@ static inline void tty_port_set_kopened(struct tty_port *port, bool val)
> > clear_bit(TTY_PORT_KOPENED, &port->iflags);
> > }
> >
> > +static inline bool tty_port_nordy(struct tty_port *port)
>
> port can be const here.

Sure, but see below.

> > +{
> > + return test_bit(TTY_PORT_NORDY, &port->iflags);
> > +}
> > +
> > +static inline void tty_port_set_nordy(struct tty_port *port, bool val)
> > +{
> > + if (val)
> > + set_bit(TTY_PORT_NORDY, &port->iflags);
> > + else
> > + clear_bit(TTY_PORT_NORDY, &port->iflags);
>
> We have assign_bit() for these cases these days.

Right, but for both your comments this follows the pattern used by the
other port-flag helpers.

I can add a preparatory patch updating the current helpers, but I don't
think this needs to be a blocker.

Johan

\
 
 \ /
  Last update: 2020-12-01 09:47    [W:0.085 / U:1.336 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site