lkml.org 
[lkml]   [2020]   [Dec]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH v2 4/4] dma-buf: heaps: add chunk heap to dmabuf heaps
On Tue, Dec 1, 2020 at 9:51 AM Minchan Kim <minchan@kernel.org> wrote:

Thanks for reworking and resending this!

...
> +static int __init chunk_heap_init(void)
> +{
> + struct cma *default_cma = dev_get_cma_area(NULL);
> + struct dma_heap_export_info exp_info;
> + struct chunk_heap *chunk_heap;
> +
> + if (!default_cma)
> + return 0;
> +
> + chunk_heap = kzalloc(sizeof(*chunk_heap), GFP_KERNEL);
> + if (!chunk_heap)
> + return -ENOMEM;
> +
> + chunk_heap->order = CHUNK_HEAP_ORDER;
> + chunk_heap->cma = default_cma;
> +
> + exp_info.name = cma_get_name(default_cma);

So, this would create a chunk heap name with the default CMA name,
which would be indistinguishable from the heap name used for the plain
CMA heap.

Probably a good idea to prefix it with "chunk-" so the heap device
names are unique?

thanks
-john

\
 
 \ /
  Last update: 2020-12-01 20:52    [W:0.172 / U:3.636 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site