Messages in this thread | | | Date | Tue, 1 Dec 2020 11:10:27 -0800 | From | Kees Cook <> | Subject | Re: [PATCH 2/9] pstore/blk: update the command line example |
| |
On Fri, Oct 16, 2020 at 03:20:40PM +0200, Christoph Hellwig wrote: > Use the human readable device name instead of the device number, and > add the required best_effort parameter. > > Signed-off-by: Christoph Hellwig <hch@lst.de>
Yeah, best_effort is needed here. I think changing from major:minor to a path is also fine.
Reviewed-by: Kees Cook <keescook@chromium.org>
> --- > Documentation/admin-guide/pstore-blk.rst | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/Documentation/admin-guide/pstore-blk.rst b/Documentation/admin-guide/pstore-blk.rst > index 296d5027787ac2..d9ec8b0572d3b2 100644 > --- a/Documentation/admin-guide/pstore-blk.rst > +++ b/Documentation/admin-guide/pstore-blk.rst > @@ -35,7 +35,7 @@ module parameters have priority over Kconfig. > > Here is an example for module parameters:: > > - pstore_blk.blkdev=179:7 pstore_blk.kmsg_size=64 > + pstore_blk.blkdev=/dev/mmcblk0p7 pstore_blk.kmsg_size=64 best_effort=y > > The detail of each configurations may be of interest to you. > > -- > 2.28.0 >
-- Kees Cook
| |