Messages in this thread | | | From | David Howells <> | Subject | Re: [PATCH 1/2] uapi: fix statx attribute value overlap for DAX & MOUNT_ROOT | Date | Tue, 01 Dec 2020 17:18:44 +0000 |
| |
Eric Sandeen <sandeen@redhat.com> wrote:
> STATX_ATTR_MOUNT_ROOT and STATX_ATTR_DAX got merged with the same value, > so one of them needs fixing. Move STATX_ATTR_DAX. > > While we're in here, clarify the value-matching scheme for some of the > attributes, and explain why the value for DAX does not match. > > Signed-off-by: Eric Sandeen <sandeen@redhat.com>
You should probably have one or two Fixes: lines in it. It might be worth referencing both of the patches that added conflicting bits.
Fixes: 80340fe3605c ("statx: add mount_root") Fixes: 712b2698e4c0 ("fs/stat: Define DAX statx attribute")
It should probably have:
Reported-by: David Howells <dhowells@redhat.com>
also as you mentioned that in the cover.
You can also add:
Reviewed-by: David Howells <dhowells@redhat.com>
David
| |