lkml.org 
[lkml]   [2020]   [Nov]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.9 025/133] chelsio/chtls: fix always leaking ctrl_skb
    Date
    From: Vinay Kumar Yadav <vinay.yadav@chelsio.com>

    [ Upstream commit dbfe394dad33f99cf8458be50483ec40a5d29c34 ]

    Correct skb refcount in alloc_ctrl_skb(), causing skb memleak
    when chtls_send_abort() called with NULL skb.
    it was always leaking the skb, correct it by incrementing skb
    refs by one.

    Fixes: cc35c88ae4db ("crypto : chtls - CPL handler definition")
    Signed-off-by: Vinay Kumar Yadav <vinay.yadav@chelsio.com>
    Link: https://lore.kernel.org/r/20201102173909.24826-1-vinay.yadav@chelsio.com
    Signed-off-by: Jakub Kicinski <kuba@kernel.org>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    ---
    drivers/crypto/chelsio/chtls/chtls_cm.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    --- a/drivers/crypto/chelsio/chtls/chtls_cm.c
    +++ b/drivers/crypto/chelsio/chtls/chtls_cm.c
    @@ -212,7 +212,7 @@ static struct sk_buff *alloc_ctrl_skb(st
    {
    if (likely(skb && !skb_shared(skb) && !skb_cloned(skb))) {
    __skb_trim(skb, 0);
    - refcount_add(2, &skb->users);
    + refcount_inc(&skb->users);
    } else {
    skb = alloc_skb(len, GFP_KERNEL | __GFP_NOFAIL);
    }

    \
     
     \ /
      Last update: 2020-11-09 14:27    [W:2.735 / U:0.176 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site