lkml.org 
[lkml]   [2020]   [Nov]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.9 024/133] chelsio/chtls: fix memory leaks caused by a race
    Date
    From: Vinay Kumar Yadav <vinay.yadav@chelsio.com>

    [ Upstream commit 8080b462b6aa856ae05ea010441a702599e579f2 ]

    race between user context and softirq causing memleak,
    consider the call sequence scenario

    chtls_setkey() //user context
    chtls_peer_close()
    chtls_abort_req_rss()
    chtls_setkey() //user context

    work request skb queued in chtls_setkey() won't be freed
    because resources are already cleaned for this connection,
    fix it by not queuing work request while socket is closing.

    v1->v2:
    - fix W=1 warning.

    v2->v3:
    - separate it out from another memleak fix.

    Fixes: cc35c88ae4db ("crypto : chtls - CPL handler definition")
    Signed-off-by: Vinay Kumar Yadav <vinay.yadav@chelsio.com>
    Link: https://lore.kernel.org/r/20201102173650.24754-1-vinay.yadav@chelsio.com
    Signed-off-by: Jakub Kicinski <kuba@kernel.org>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    ---
    drivers/crypto/chelsio/chtls/chtls_hw.c | 3 +++
    1 file changed, 3 insertions(+)

    --- a/drivers/crypto/chelsio/chtls/chtls_hw.c
    +++ b/drivers/crypto/chelsio/chtls/chtls_hw.c
    @@ -383,6 +383,9 @@ int chtls_setkey(struct chtls_sock *csk,
    if (ret)
    goto out_notcb;

    + if (unlikely(csk_flag(sk, CSK_ABORT_SHUTDOWN)))
    + goto out_notcb;
    +
    set_wr_txq(skb, CPL_PRIORITY_DATA, csk->tlshws.txqid);
    csk->wr_credits -= DIV_ROUND_UP(len, 16);
    csk->wr_unacked += DIV_ROUND_UP(len, 16);

    \
     
     \ /
      Last update: 2020-11-09 14:16    [W:4.028 / U:0.172 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site