Messages in this thread | | | Date | Tue, 10 Nov 2020 11:23:58 +1100 | From | Stephen Rothwell <> | Subject | Re: [PATCH -next v2] clk: pm_clock: provide stubs for pm_clk_runtime_suspend/_resume |
| |
Hi all,
On Sun, 8 Nov 2020 19:21:15 -0800 Randy Dunlap <rdunlap@infradead.org> wrote: > > Add stubs for pm_clk_runtime_suspend() and pm_clk_runtime_resume() > to fix build errors when CONFIG_PM and CONFIG_PM_CLK are not enabled. > > Fixes these build errors: > > ../drivers/clk/qcom/camcc-sc7180.c: In function ‘cam_cc_sc7180_probe’: > ../drivers/clk/qcom/camcc-sc7180.c:1672:8: error: implicit declaration of function ‘pm_clk_runtime_resume’; did you mean ‘pm_runtime_resume’? [-Werror=implicit-function-declaration] > ret = pm_clk_runtime_resume(&pdev->dev); > ^~~~~~~~~~~~~~~~~~~~~ > ../drivers/clk/qcom/camcc-sc7180.c:1681:3: error: implicit declaration of function ‘pm_clk_runtime_suspend’; did you mean ‘pm_runtime_suspend’? [-Werror=implicit-function-declaration] > pm_clk_runtime_suspend(&pdev->dev); > ^~~~~~~~~~~~~~~~~~~~~~ > > Fixes: 15d09e830bbc ("clk: qcom: camcc: Add camera clock controller driver for SC7180") > Signed-off-by: Randy Dunlap <rdunlap@infradead.org> > Cc: "Rafael J. Wysocki" <rjw@rjwysocki.net> > Cc: Len Brown <len.brown@intel.com> > Cc: Pavel Machek <pavel@ucw.cz> > Cc: linux-pm@vger.kernel.org > Cc: Michael Turquette <mturquette@baylibre.com> > Cc: Stephen Boyd <sboyd@kernel.org> > Cc: linux-clk@vger.kernel.org > Cc: Taniya Das <tdas@codeaurora.org> > Cc: linux-next@vger.kernel.org > Cc: Nathan Chancellor <natechancellor@gmail.com> > Cc: Andrew Morton <akpm@linux-foundation.org> > --- > v2: move the function stubs to be inside the #else (for !CONFIG_PM) > as suggested by Nathan to fix another build error > > include/linux/pm_clock.h | 8 ++++++++ > 1 file changed, 8 insertions(+)
I have added this to the merge of to clk tree in linux-next today (pending it being added to the clk tree itself).
-- Cheers, Stephen Rothwell [unhandled content-type:application/pgp-signature] | |