Messages in this thread | | | Subject | Re: [PATCH v1 17/30] mmc: sdhci-tegra: Support OPP and core voltage scaling | From | Dmitry Osipenko <> | Date | Mon, 9 Nov 2020 08:44:22 +0300 |
| |
09.11.2020 08:35, Viresh Kumar пишет: > On 09-11-20, 08:19, Dmitry Osipenko wrote: >> Thanks, I made it in a different way by simply adding helpers to the >> pm_opp.h which use devm_add_action_or_reset(). This doesn't require to >> add new kernel symbols. > > I will prefer to add it in core.c itself, and yes > devm_add_action_or_reset() looks better. But I am still not sure for > which helpers do we need the devm_*() variants, as this is only useful > for non-CPU devices. But if we have users that we can add right now, > why not.
All current non-CPU drivers (devfreq, mmc, memory, etc) can benefit from it.
For Tegra drivers we need these variants:
devm_pm_opp_set_supported_hw() devm_pm_opp_set_regulators() [if we won't use GENPD] devm_pm_opp_set_clkname() devm_pm_opp_of_add_table()
| |