lkml.org 
[lkml]   [2020]   [Nov]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    SubjectRe: [PATCH 17/19] drm/radeon/radeon_kms: Fix misnaming of 'radeon_info_ioctl's dev param
    On Mon, Nov 09, 2020 at 08:10:13PM +0000, Lee Jones wrote:
    > On Mon, 09 Nov 2020, Sam Ravnborg wrote:
    >
    > > Hi Alex,
    > > On Mon, Nov 09, 2020 at 02:50:35PM -0500, Alex Deucher wrote:
    > > > On Fri, Nov 6, 2020 at 4:50 PM Lee Jones <lee.jones@linaro.org> wrote:
    > > > >
    > > > > Fixes the following W=1 kernel build warning(s):
    > > > >
    > > > > drivers/gpu/drm/radeon/radeon_kms.c:226: warning: Function parameter or member 'dev' not described in 'radeon_info_ioctl'
    > > > > drivers/gpu/drm/radeon/radeon_kms.c:226: warning: Excess function parameter 'rdev' description in 'radeon_info_ioctl'
    > > > >
    > > > > Cc: Alex Deucher <alexander.deucher@amd.com>
    > > > > Cc: "Christian König" <christian.koenig@amd.com>
    > > > > Cc: David Airlie <airlied@linux.ie>
    > > > > Cc: Daniel Vetter <daniel@ffwll.ch>
    > > > > Cc: amd-gfx@lists.freedesktop.org
    > > > > Cc: dri-devel@lists.freedesktop.org
    > > > > Signed-off-by: Lee Jones <lee.jones@linaro.org>
    > > > > ---
    > > > > drivers/gpu/drm/radeon/radeon_kms.c | 2 +-
    > > > > 1 file changed, 1 insertion(+), 1 deletion(-)
    > > > >
    > > > > diff --git a/drivers/gpu/drm/radeon/radeon_kms.c b/drivers/gpu/drm/radeon/radeon_kms.c
    > > > > index 0d8fbabffcead..21c206795c364 100644
    > > > > --- a/drivers/gpu/drm/radeon/radeon_kms.c
    > > > > +++ b/drivers/gpu/drm/radeon/radeon_kms.c
    > > > > @@ -213,7 +213,7 @@ static void radeon_set_filp_rights(struct drm_device *dev,
    > > > > /**
    > > > > * radeon_info_ioctl - answer a device specific request.
    > > > > *
    > > > > - * @rdev: radeon device pointer
    > > > > + * @dev: radeon device pointer
    > > >
    > > > This should be:
    > > > + * @dev: drm device pointer
    > >
    > > good spot. I am continuing the work on radeon and will post a patchset
    > > that contains only radeon fixes with Lee's patches and a few more by me.
    > > I will fix the above.
    >
    > What do you mean by "continuing on"?
    >
    > How will you prevent your work from conflicting with my current effort?

    Quoting from previous mail in this thread:

    "
    > > How would you like me to move forward?
    >
    > Fix the thousand of warnings in other places :-)
    > I will take a look at radeon and post a new series based on your work
    > with all W=1 warnings fixed.
    I'll drop this patch and carry on ploughing through the rest of them.
    "

    Here I promised you to fix all warnings in the radeon driver.
    And despite this being more work than anticipated a promise is a
    promise. So therefore I started working on this.

    If you want to do the rest of the radeon driver you are welcome and I
    will gladly drop this again. Just let me know your preference.

    Sam

    \
     
     \ /
      Last update: 2020-11-09 21:53    [W:3.214 / U:0.328 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site