lkml.org 
[lkml]   [2020]   [Nov]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5/5] Revert "genirq: Add fasteoi IPI flow"
    Date
    handle_percpu_devid_fasteoi_ipi() has no more users, and
    handle_percpu_devid_irq() can do all that it was supposed to do. Get rid of
    it.

    This reverts commit c5e5ec033c4ab25c53f1fd217849e75deb0bf7bf.

    Signed-off-by: Valentin Schneider <valentin.schneider@arm.com>
    ---
    include/linux/irq.h | 1 -
    kernel/irq/chip.c | 27 ---------------------------
    2 files changed, 28 deletions(-)

    diff --git a/include/linux/irq.h b/include/linux/irq.h
    index c54365309e97..ca26bec51cec 100644
    --- a/include/linux/irq.h
    +++ b/include/linux/irq.h
    @@ -647,7 +647,6 @@ static inline int irq_set_parent(int irq, int parent_irq)
    */
    extern void handle_level_irq(struct irq_desc *desc);
    extern void handle_fasteoi_irq(struct irq_desc *desc);
    -extern void handle_percpu_devid_fasteoi_ipi(struct irq_desc *desc);
    extern void handle_edge_irq(struct irq_desc *desc);
    extern void handle_edge_eoi_irq(struct irq_desc *desc);
    extern void handle_simple_irq(struct irq_desc *desc);
    diff --git a/kernel/irq/chip.c b/kernel/irq/chip.c
    index b9b9618e1aca..0ae308efa604 100644
    --- a/kernel/irq/chip.c
    +++ b/kernel/irq/chip.c
    @@ -944,33 +944,6 @@ void handle_percpu_devid_irq(struct irq_desc *desc)
    chip->irq_eoi(&desc->irq_data);
    }

    -/**
    - * handle_percpu_devid_fasteoi_ipi - Per CPU local IPI handler with per cpu
    - * dev ids
    - * @desc: the interrupt description structure for this irq
    - *
    - * The biggest difference with the IRQ version is that the interrupt is
    - * EOIed early, as the IPI could result in a context switch, and we need to
    - * make sure the IPI can fire again. We also assume that the arch code has
    - * registered an action. If not, we are positively doomed.
    - */
    -void handle_percpu_devid_fasteoi_ipi(struct irq_desc *desc)
    -{
    - struct irq_chip *chip = irq_desc_get_chip(desc);
    - struct irqaction *action = desc->action;
    - unsigned int irq = irq_desc_get_irq(desc);
    - irqreturn_t res;
    -
    - __kstat_incr_irqs_this_cpu(desc);
    -
    - if (chip->irq_eoi)
    - chip->irq_eoi(&desc->irq_data);
    -
    - trace_irq_handler_entry(irq, action);
    - res = action->handler(irq, raw_cpu_ptr(action->percpu_dev_id));
    - trace_irq_handler_exit(irq, action, res);
    -}
    -
    /**
    * handle_percpu_devid_fasteoi_nmi - Per CPU local NMI handler with per cpu
    * dev ids
    --
    2.27.0
    \
     
     \ /
      Last update: 2020-11-09 10:43    [W:2.352 / U:0.028 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site