Messages in this thread | | | Date | Mon, 9 Nov 2020 10:12:04 -0800 | From | Eric Biggers <> | Subject | Re: [f2fs-dev] [PATCH v4 2/2] f2fs: fix compat F2FS_IOC_{MOVE, GARBAGE_COLLECT}_RANGE |
| |
On Mon, Nov 09, 2020 at 10:29:25AM +0800, Chao Yu wrote: > > Oh I see, the cp-related checks are at the beginning of f2fs_ioctl() too. > > > > In that case a much better approach would be to add __f2fs_ioctl() which is > > called by f2fs_ioctl() and f2fs_compat_ioctl(), and have f2fs_ioctl() and > > f2fs_compat_ioctl() do the cp-related checks but not __f2fs_ioctl(). > > Will this cleanup make sense to you?
I think it would be better to do it the way I suggested.
- Eric
| |