Messages in this thread | | | From | Andy Shevchenko <> | Date | Mon, 9 Nov 2020 17:16:49 +0200 | Subject | Re: [PATCH v8 2/3] pinctrl: pinctrl-microchip-sgpio: Add pinctrl driver for Microsemi Serial GPIO |
| |
On Mon, Nov 9, 2020 at 4:32 PM Alexandre Belloni <alexandre.belloni@bootlin.com> wrote: > On 09/11/2020 16:17:40+0200, Andy Shevchenko wrote: > > > + if (input != bank->is_input) { > > > > > + dev_err(pctldev->dev, "Pin %d direction as %s is not possible\n", > > > + pin, input ? "input" : "output"); > > > > Do we need this noise? Isn't user space getting a proper error code as > > per doc and can handle this? > > Why would userspace get the error code?
Huh?! Why it shouldn't. How will users know if they are doing something wrong?
> Userspace should never have to > handle gpios directly or you are doing something wrong.
This is true, but check how error codes are propagated to the user space.
-- With Best Regards, Andy Shevchenko
| |