lkml.org 
[lkml]   [2020]   [Nov]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [PATCH v13 05/14] KVM: X86: Implement ring-based dirty memory tracking
    From
    Date
    Just very few changes:

    On 01/10/20 03:22, Peter Xu wrote:
    > @@ -6373,3 +6386,107 @@ ranges that KVM should reject access to.
    > In combination with KVM_CAP_X86_USER_SPACE_MSR, this allows user space to
    > trap and emulate MSRs that are outside of the scope of KVM as well as
    > limit the attack surface on KVM's MSR emulation code.
    > +
    > +8.28 KVM_CAP_DIRTY_LOG_RING
    > +---------------------------

    Here I made a few edits, but nothing major. Throughout the patch I
    replaced "collected" with "harvested" since the documentation was using
    it already and it's a bit more unique ("collect" reminds me too much of
    garbage collection and perhaps could be confused with the kernel's
    operation for the reset ioctl).

    > +#ifdef CONFIG_X86
    > + return KVM_DIRTY_RING_MAX_ENTRIES * sizeof(struct kvm_dirty_gfn);
    > +#else
    > + return 0;
    > +#endif

    And this can be "#if KVM_DIRTY_LOG_PAGE_OFFSET > 0" instead.

    Paolo

    \
     
     \ /
      Last update: 2020-11-06 11:57    [W:4.366 / U:0.008 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site