lkml.org 
[lkml]   [2020]   [Nov]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    SubjectRe: [PATCH 10/20] input: mouse: synaptics: Place braces around empty if() body
    Hi Lee,

    On Wed, Nov 04, 2020 at 04:24:17PM +0000, Lee Jones wrote:
    > Fixes the following W=1 kernel build warning(s):
    >
    > drivers/input/mouse/synaptics.c: In function ‘synaptics_process_packet’:
    > drivers/input/mouse/synaptics.c:1110:6: warning: suggest braces around empty body in an ‘if’ statement [-Wempty-body]
    >
    > Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>
    > Cc: Henrik Rydberg <rydberg@bitmath.org>
    > Cc: Peter Osterlund <petero2@telia.com>
    > Cc: Stefan Gmeiner <riddlebox@freesurf.ch>
    > Cc: "C. Scott Ananian" <cananian@alumni.priceton.edu>
    > Cc: Bruce Kalk <kall@compass.com>
    > Cc: this to <linux-input@vger.kernel.org>
    > Cc: linux-input@vger.kernel.org
    > Signed-off-by: Lee Jones <lee.jones@linaro.org>
    > ---
    > drivers/input/mouse/synaptics.c | 3 ++-
    > 1 file changed, 2 insertions(+), 1 deletion(-)
    >
    > diff --git a/drivers/input/mouse/synaptics.c b/drivers/input/mouse/synaptics.c
    > index 82577095e175e..07835939d83b9 100644
    > --- a/drivers/input/mouse/synaptics.c
    > +++ b/drivers/input/mouse/synaptics.c
    > @@ -1106,8 +1106,9 @@ static void synaptics_process_packet(struct psmouse *psmouse)
    > num_fingers = hw.w + 2;
    > break;
    > case 2:
    > - if (SYN_MODEL_PEN(info->model_id))
    > + if (SYN_MODEL_PEN(info->model_id)) {
    > ; /* Nothing, treat a pen as a single finger */
    > + }

    This gives me:

    WARNING: braces {} are not necessary for single statement blocks

    from checkpatch.

    Thanks.

    --
    Dmitry

    \
     
     \ /
      Last update: 2020-11-06 08:27    [W:4.048 / U:0.352 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site