Messages in this thread | | | Date | Fri, 6 Nov 2020 08:20:59 +0100 | From | Greg Kroah-Hartman <> | Subject | Re: [PATCH 6/6] platform/chrome: cros_ec_typec: Store cable plug type |
| |
On Thu, Nov 05, 2020 at 05:28:03PM -0800, Prashant Malani wrote: > Use the PD VDO Type C cable plug type macro to retrieve and store the > cable plug type in the cable descriptor. > > Cc: Heikki Krogerus <heikki.krogerus@linux.intel.com> > Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org> > Signed-off-by: Prashant Malani <pmalani@chromium.org> > --- > drivers/platform/chrome/cros_ec_typec.c | 21 ++++++++++++++++++++- > 1 file changed, 20 insertions(+), 1 deletion(-)
Where are the first 5 patches in this series?
> > diff --git a/drivers/platform/chrome/cros_ec_typec.c b/drivers/platform/chrome/cros_ec_typec.c > index 5e7f0b4ebbec..0a2a8b0f8115 100644 > --- a/drivers/platform/chrome/cros_ec_typec.c > +++ b/drivers/platform/chrome/cros_ec_typec.c > @@ -709,6 +709,7 @@ static int cros_typec_handle_sop_prime_disc(struct cros_typec_data *typec, int p > .port = port_num, > .partner_type = TYPEC_PARTNER_SOP_PRIME, > }; > + uint32_t cable_plug_type;
u32 please, this isn't userspace code :)
> int ret = 0; > > memset(disc, 0, EC_PROTO2_MAX_RESPONSE_SIZE); > @@ -722,8 +723,26 @@ static int cros_typec_handle_sop_prime_disc(struct cros_typec_data *typec, int p > /* Parse the PD identity data, even if only 0s were returned. */ > cros_typec_parse_pd_identity(&port->c_identity, disc); > > - if (disc->identity_count != 0) > + if (disc->identity_count != 0) { > + cable_plug_type = VDO_TYPEC_CABLE_TYPE(port->c_identity.vdo[0]); > + switch (cable_plug_type) { > + case CABLE_ATYPE: > + desc.type = USB_PLUG_TYPE_A; > + break; > + case CABLE_BTYPE: > + desc.type = USB_PLUG_TYPE_B; > + break; > + case CABLE_CTYPE: > + desc.type = USB_PLUG_TYPE_C; > + break; > + case CABLE_CAPTIVE: > + desc.type = USB_PLUG_CAPTIVE; > + break; > + default: > + desc.type = USB_PLUG_NONE; > + } > desc.active = PD_IDH_PTYPE(port->c_identity.id_header) == IDH_PTYPE_ACABLE; > + }
So you save it but what happens with the value?
confused,
greg k-h
| |