lkml.org 
[lkml]   [2020]   [Nov]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 03/19] drm/selftests/test-drm_dp_mst_helper: Move 'sideband_msg_req_encode_decode' onto the heap
    Date
    There is too much data being stored on the stack.

    Fixes the following W=1 kernel build warning(s):

    drivers/gpu/drm/selftests/test-drm_dp_mst_helper.c: In function ‘sideband_msg_req_encode_decode’:
    drivers/gpu/drm/selftests/test-drm_dp_mst_helper.c:168:1: warning: the frame size of 1072 bytes is larger than 1024 bytes [-Wframe-larger-than=]

    Cc: David Airlie <airlied@linux.ie>
    Cc: Daniel Vetter <daniel@ffwll.ch>
    Cc: dri-devel@lists.freedesktop.org
    Signed-off-by: Lee Jones <lee.jones@linaro.org>
    ---
    drivers/gpu/drm/selftests/test-drm_dp_mst_helper.c | 11 ++++++++---
    1 file changed, 8 insertions(+), 3 deletions(-)

    diff --git a/drivers/gpu/drm/selftests/test-drm_dp_mst_helper.c b/drivers/gpu/drm/selftests/test-drm_dp_mst_helper.c
    index e00bdc557f880..6b4759ed6bfd4 100644
    --- a/drivers/gpu/drm/selftests/test-drm_dp_mst_helper.c
    +++ b/drivers/gpu/drm/selftests/test-drm_dp_mst_helper.c
    @@ -122,7 +122,7 @@ sideband_msg_req_encode_decode(struct drm_dp_sideband_msg_req_body *in)
    {
    struct drm_dp_sideband_msg_req_body *out;
    struct drm_printer p = drm_err_printer(PREFIX_STR);
    - struct drm_dp_sideband_msg_tx txmsg;
    + struct drm_dp_sideband_msg_tx *txmsg;
    int i, ret;
    bool result = true;

    @@ -130,8 +130,12 @@ sideband_msg_req_encode_decode(struct drm_dp_sideband_msg_req_body *in)
    if (!out)
    return false;

    - drm_dp_encode_sideband_req(in, &txmsg);
    - ret = drm_dp_decode_sideband_req(&txmsg, out);
    + txmsg = kzalloc(sizeof(*txmsg), GFP_KERNEL);
    + if (!txmsg)
    + return false;
    +
    + drm_dp_encode_sideband_req(in, txmsg);
    + ret = drm_dp_decode_sideband_req(txmsg, out);
    if (ret < 0) {
    drm_printf(&p, "Failed to decode sideband request: %d\n",
    ret);
    @@ -166,6 +170,7 @@ sideband_msg_req_encode_decode(struct drm_dp_sideband_msg_req_body *in)

    out:
    kfree(out);
    + kfree(txmsg);
    return result;
    }

    --
    2.25.1
    \
     
     \ /
      Last update: 2020-11-06 22:51    [W:4.389 / U:0.624 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site