lkml.org 
[lkml]   [2020]   [Nov]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH 1/4] clk: sifive: Extract prci core to common base
On Thu, Nov 5, 2020 at 10:45 AM Stephen Boyd <sboyd@kernel.org> wrote:
>
> Quoting Zong Li (2020-10-16 02:18:23)
> > Extract common core of prci driver to an independent file, it could
> > allow other chips to reuse it. Separate SoCs-dependent code 'fu540'
> > from prci core, then we can easily add 'fu740' later.
>
> Please indicate if there are any functional changes or this is just code
> movement.

There are some changes for common use, not just code movement or
copies, I would figure out the changes in the commit message in the
next version.

>
> >
> > Signed-off-by: Zong Li <zong.li@sifive.com>
> > ---
> > drivers/clk/sifive/Makefile | 2 +
> > drivers/clk/sifive/fu540-prci.c | 586 +------------------------------
> > drivers/clk/sifive/fu540-prci.h | 21 ++
> > drivers/clk/sifive/sifive-prci.c | 409 +++++++++++++++++++++
> > drivers/clk/sifive/sifive-prci.h | 201 +++++++++++
>
> How much of this is a copy/pastes? Can you generate patches with
> format-patch -M -C to try to find copies and renames?

I tried to add -M and -C option to find renames and copies, but it
doesn't detect anything here.

>
> > 5 files changed, 652 insertions(+), 567 deletions(-)
> > create mode 100644 drivers/clk/sifive/fu540-prci.h
> > create mode 100644 drivers/clk/sifive/sifive-prci.c
> > create mode 100644 drivers/clk/sifive/sifive-prci.h
> >

\
 
 \ /
  Last update: 2020-11-05 08:23    [W:0.071 / U:2.436 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site