Messages in this thread | | | From | Andrey Konovalov <> | Date | Thu, 5 Nov 2020 13:14:33 +0100 | Subject | Re: [PATCH v8 30/43] arm64: kasan: Allow enabling in-kernel MTE |
| |
On Thu, Nov 5, 2020 at 12:39 PM Vincenzo Frascino <vincenzo.frascino@arm.com> wrote: > > On 11/5/20 11:35 AM, Andrey Konovalov wrote: > > This will work. Any preference on the name of this function? > > > > I called it in my current iteration mte_enable(), and calling it from > cpu_enable_mte(). > > > Alternatively we can rename mte_init_tags() to something else and let > > it handle both RRND and sync/async. > > This is an option but then you need to change the name of kasan_init_tags and > the init_tags indirection name as well. I would go for the simpler and just > splitting the function as per above. > > What do you think?
OK, let's split. mte_enable() as a name sounds good to me. Both functions will still be called one right after another from kasan_init_hw_tags (as it's now called) though. I think the name works, as it means initializing the hw_tags mode, not just the tags.
Will do in v9.
| |