| Date | Thu, 5 Nov 2020 12:46:48 +0100 | From | Pavel Machek <> | Subject | Re: [PATCH 4.19 107/191] ARM: dts: s5pv210: move PMU node out of clock controller |
| |
Hi!
> The Power Management Unit (PMU) is a separate device which has little > common with clock controller. Moving it to one level up (from clock > controller child to SoC) allows to remove fake simple-bus compatible and > dtbs_check warnings like: > > clock-controller@e0100000: $nodename:0: > 'clock-controller@e0100000' does not match '^([a-z][a-z0-9\\-]+-bus|bus|soc|axi|ahb|apb)(@[0-9a-f]+)?$'
> +++ b/arch/arm/boot/dts/s5pv210.dtsi > @@ -98,19 +98,16 @@ > }; > > clocks: clock-controller@e0100000 { > - compatible = "samsung,s5pv210-clock", "simple-bus"; > + compatible = "samsung,s5pv210-clock"; > reg = <0xe0100000 0x10000>; ... > + pmu_syscon: syscon@e0108000 { > + compatible = "samsung-s5pv210-pmu", "syscon"; > + reg = <0xe0108000 0x8000>; > };
Should clock-controller@e0100000's reg be shortened to 0x8000 so that the ranges do not overlap?
Signed-off-by: Pavel Machek (CIP) <pavel@denx.de>
Best regards, Pavel
diff --git a/arch/arm/boot/dts/s5pv210.dtsi b/arch/arm/boot/dts/s5pv210.dtsi index 020a864623ff..54fc3fb56ca1 100644 --- a/arch/arm/boot/dts/s5pv210.dtsi +++ b/arch/arm/boot/dts/s5pv210.dtsi @@ -99,7 +99,7 @@ clocks: clock-controller@e0100000 { compatible = "samsung,s5pv210-clock"; - reg = <0xe0100000 0x10000>; + reg = <0xe0100000 0x8000>; clock-names = "xxti", "xusbxti"; clocks = <&xxti>, <&xusbxti>; #clock-cells = <1>;
-- http://www.livejournal.com/~pavelmachek [unhandled content-type:application/pgp-signature] |