lkml.org 
[lkml]   [2020]   [Nov]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH tip/core/rcu 16/28] rcutorture: Prevent hangs for invalid arguments
    Date
    From: "Paul E. McKenney" <paulmck@kernel.org>

    If an rcutorture torture-test run is given a bad kvm.sh argument, the
    test will complain to the console, which is good. What is bad is that
    from the user's perspective, it will just hang for the time specified
    by the --duration argument. This commit therefore forces an immediate
    kernel shutdown if a rcu_torture_init()-time error occurs, thus avoiding
    the appearance of a hang. It also forces a console splat in this case
    to clearly indicate the presence of an error.

    Signed-off-by: Paul E. McKenney <paulmck@kernel.org>
    ---
    kernel/rcu/rcutorture.c | 5 ++++-
    1 file changed, 4 insertions(+), 1 deletion(-)

    diff --git a/kernel/rcu/rcutorture.c b/kernel/rcu/rcutorture.c
    index 916ea4f..db37671 100644
    --- a/kernel/rcu/rcutorture.c
    +++ b/kernel/rcu/rcutorture.c
    @@ -2647,7 +2647,6 @@ rcu_torture_init(void)
    for (i = 0; i < ARRAY_SIZE(torture_ops); i++)
    pr_cont(" %s", torture_ops[i]->name);
    pr_cont("\n");
    - WARN_ON(!IS_MODULE(CONFIG_RCU_TORTURE_TEST));
    firsterr = -EINVAL;
    cur_ops = NULL;
    goto unwind;
    @@ -2815,6 +2814,10 @@ rcu_torture_init(void)
    unwind:
    torture_init_end();
    rcu_torture_cleanup();
    + if (shutdown_secs) {
    + WARN_ON(!IS_MODULE(CONFIG_RCU_TORTURE_TEST));
    + kernel_power_off();
    + }
    return firsterr;
    }

    --
    2.9.5
    \
     
     \ /
      Last update: 2020-11-06 00:49    [W:2.787 / U:0.016 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site