Messages in this thread | | | Date | Wed, 4 Nov 2020 13:06:12 -0600 | From | Rob Herring <> | Subject | Re: [PATCH v3 09/11] dt-bindings: pwm: Add binding for RPi firmware PWM bus |
| |
On Wed, 04 Nov 2020 11:39:35 +0100, Nicolas Saenz Julienne wrote: > The PWM bus controlling the fan in RPi's official PoE hat can only be > controlled by the board's co-processor. > > Signed-off-by: Nicolas Saenz Julienne <nsaenzjulienne@suse.de> > Reviewed-by: Rob Herring <robh@kernel.org> > > --- > > Changes since v1: > - Update bindings to use 2 #pwm-cells > > .../arm/bcm/raspberrypi,bcm2835-firmware.yaml | 20 +++++++++++++++++++ > .../pwm/raspberrypi,firmware-pwm.h | 13 ++++++++++++ > 2 files changed, 33 insertions(+) > create mode 100644 include/dt-bindings/pwm/raspberrypi,firmware-pwm.h >
My bot found errors running 'make dt_binding_check' on your patch:
yamllint warnings/errors:
dtschema/dtc warnings/errors: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/arm/bcm/raspberrypi,bcm2835-firmware.example.dt.yaml: firmware: pwm:#pwm-cells:0:0: 2 was expected From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/arm/bcm/raspberrypi,bcm2835-firmware.yaml
See https://patchwork.ozlabs.org/patch/1393804
The base for the patch is generally the last rc1. Any dependencies should be noted.
If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date:
pip3 install dtschema --upgrade
Please check and re-submit.
| |