lkml.org 
[lkml]   [2020]   [Nov]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH v40 03/24] x86/sgx: Initialize metadata for Enclave Page Cache (EPC) sections
    On Wed, Nov 04, 2020 at 04:54:09PM +0200, Jarkko Sakkinen wrote:
    > +static void __init sgx_init(void)
    > +{
    > + int i;
    > +
    > + if (!boot_cpu_has(X86_FEATURE_SGX))

    Guys, you need to build-test *every* *single* patch - otherwise we break
    bisectability and that is a no-no:

    arch/x86/kernel/cpu/sgx/main.c: In function ‘sgx_init’:
    arch/x86/kernel/cpu/sgx/main.c:172:20: error: ‘X86_FEATURE_SGX’ undeclared (first use in this function); did you mean ‘X86_FEATURE_SMX’?
    172 | if (!boot_cpu_has(X86_FEATURE_SGX))
    | ^~~~~~~~~~~~~~~
    ./arch/x86/include/asm/cpufeature.h:118:24: note: in definition of macro ‘cpu_has’
    118 | (__builtin_constant_p(bit) && REQUIRED_MASK_BIT_SET(bit) ? 1 : \
    | ^~~
    arch/x86/kernel/cpu/sgx/main.c:172:7: note: in expansion of macro ‘boot_cpu_has’
    172 | if (!boot_cpu_has(X86_FEATURE_SGX))
    | ^~~~~~~~~~~~
    arch/x86/kernel/cpu/sgx/main.c:172:20: note: each undeclared identifier is reported only once for each function it appears in
    172 | if (!boot_cpu_has(X86_FEATURE_SGX))
    | ^~~~~~~~~~~~~~~
    ./arch/x86/include/asm/cpufeature.h:118:24: note: in definition of macro ‘cpu_has’
    118 | (__builtin_constant_p(bit) && REQUIRED_MASK_BIT_SET(bit) ? 1 : \
    | ^~~
    arch/x86/kernel/cpu/sgx/main.c:172:7: note: in expansion of macro ‘boot_cpu_has’
    172 | if (!boot_cpu_has(X86_FEATURE_SGX))
    | ^~~~~~~~~~~~
    make[4]: *** [scripts/Makefile.build:283: arch/x86/kernel/cpu/sgx/main.o] Error 1
    make[3]: *** [scripts/Makefile.build:500: arch/x86/kernel/cpu/sgx] Error 2
    make[2]: *** [scripts/Makefile.build:500: arch/x86/kernel/cpu] Error 2
    make[2]: *** Waiting for unfinished jobs....
    make[1]: *** [scripts/Makefile.build:500: arch/x86/kernel] Error 2
    make[1]: *** Waiting for unfinished jobs....
    make: *** [Makefile:1799: arch/x86] Error 2
    make: *** Waiting for unfinished jobs....

    --
    Regards/Gruss,
    Boris.

    https://people.kernel.org/tglx/notes-about-netiquette

    \
     
     \ /
      Last update: 2020-11-04 19:22    [W:2.920 / U:0.004 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site