Messages in this thread | | | From | Shakeel Butt <> | Date | Wed, 4 Nov 2020 06:58:34 -0800 | Subject | Re: [PATCH rfc 1/3] mm: memcg: deprecate the non-hierarchical mode |
| |
On Tue, Nov 3, 2020 at 1:27 PM Roman Gushchin <guro@fb.com> wrote: > > The non-hierarchical cgroup v1 mode is a legacy of early days > of the memory controller and doesn't bring any value today. > However, it complicates the code and creates many edge cases > all over the memory controller code. > > It's a good time to deprecate it completely. > > Functionally this patch enabled is by default for all cgroups > and forbids switching it off. Nothing changes if cgroup v2 is used: > hierarchical mode was enforced from scratch. > > To protect the ABI memory.use_hierarchy interface is preserved > with a limited functionality: reading always returns "1", writing > of "1" passes silently, writing of any other value fails with > -EINVAL and a warning to dmesg (on the first occasion). > > Signed-off-by: Roman Gushchin <guro@fb.com>
Reviewed-by: Shakeel Butt <shakeelb@google.com>
| |