Messages in this thread | | | Subject | Re: [PATCH 08/12] net: xen-netfront: Demote non-kernel-doc headers to standard comment blocks | From | Jürgen Groß <> | Date | Wed, 4 Nov 2020 10:31:43 +0100 |
| |
On 04.11.20 10:06, Lee Jones wrote: > Fixes the following W=1 kernel build warning(s): > > drivers/net/xen-netfront.c: In function ‘store_rxbuf’: > drivers/net/xen-netfront.c:2416:16: warning: variable ‘target’ set but not used [-Wunused-but-set-variable]
Those two warnings are not fixed by the patch.
> drivers/net/xen-netfront.c:1592: warning: Function parameter or member 'dev' not described in 'netfront_probe' > drivers/net/xen-netfront.c:1592: warning: Function parameter or member 'id' not described in 'netfront_probe' > drivers/net/xen-netfront.c:1669: warning: Function parameter or member 'dev' not described in 'netfront_resume' > drivers/net/xen-netfront.c:2313: warning: Function parameter or member 'dev' not described in 'netback_changed' > drivers/net/xen-netfront.c:2313: warning: Function parameter or member 'backend_state' not described in 'netback_changed' > > Cc: Boris Ostrovsky <boris.ostrovsky@oracle.com> > Cc: Juergen Gross <jgross@suse.com> > Cc: Stefano Stabellini <sstabellini@kernel.org> > Cc: "David S. Miller" <davem@davemloft.net> > Cc: Jakub Kicinski <kuba@kernel.org> > Cc: Alexei Starovoitov <ast@kernel.org> > Cc: Daniel Borkmann <daniel@iogearbox.net> > Cc: Jesper Dangaard Brouer <hawk@kernel.org> > Cc: John Fastabend <john.fastabend@gmail.com> > Cc: Martin KaFai Lau <kafai@fb.com> > Cc: Song Liu <songliubraving@fb.com> > Cc: Yonghong Song <yhs@fb.com> > Cc: Andrii Nakryiko <andrii@kernel.org> > Cc: KP Singh <kpsingh@chromium.org> > Cc: xen-devel@lists.xenproject.org > Cc: netdev@vger.kernel.org > Cc: bpf@vger.kernel.org > Signed-off-by: Lee Jones <lee.jones@linaro.org>
With the commit message fixed you can have my:
Reviewed-by: Juergen Gross <jgross@suse.com>
Juergen
| |