lkml.org 
[lkml]   [2020]   [Nov]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    Date
    SubjectRe: [PATCH mlx5-next v1 06/11] vdpa/mlx5: Connect mlx5_vdpa to auxiliary bus
    On Tue, Nov 3, 2020 at 7:45 AM Jason Gunthorpe <jgg@ziepe.ca> wrote:
    [..]
    > > +MODULE_DEVICE_TABLE(auxiliary, mlx5v_id_table);
    > > +
    > > +static struct auxiliary_driver mlx5v_driver = {
    > > + .name = "vnet",
    > > + .probe = mlx5v_probe,
    > > + .remove = mlx5v_remove,
    > > + .id_table = mlx5v_id_table,
    > > +};
    >
    > It is hard to see from the diff, but when this patch is applied the
    > vdpa module looks like I imagined things would look with the auxiliary
    > bus. It is very similar in structure to a PCI driver with the probe()
    > function cleanly registering with its subsystem. This is what I'd like
    > to see from the new Intel RDMA driver.
    >
    > Greg, I think this patch is the best clean usage example.
    >
    > I've looked over this series and it has the right idea and
    > parts. There is definitely more that can be done to improve mlx5 in
    > this area, but this series is well scoped and cleans a good part of
    > it.

    Greg?

    I know you alluded to going your own way if the auxiliary bus patches
    did not shape up soon, but it seems they have and the stakeholders
    have reached this consensus point.

    Were there any additional changes you wanted to see happen? I'll go
    give the final set another once over, but David has been diligently
    fixing up all the declared major issues so I expect to find at most
    minor incremental fixups.

    \
     
     \ /
      Last update: 2020-11-05 00:22    [W:2.643 / U:0.136 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site