Messages in this thread Patch in this message | | | From | Chris Ruehl <> | Subject | [PATCH] phy: rockchip-emmc: emmc_phy_init() always return 0 | Date | Tue, 1 Dec 2020 11:10:14 +0800 |
| |
rockchip_emmc_phy_init() return variable is not set with the error value if clk_get() failed. The debug message print 0 on error and the function always return 0. Fix it using PTR_ERR().
Fixes: 52c0624a10cce phy: rockchip-emmc: Set phyctrl_frqsel based on card clock
Signed-off-by: Chris Ruehl <chris.ruehl@gtsys.com.hk> --- drivers/phy/rockchip/phy-rockchip-emmc.c | 1 + 1 file changed, 1 insertion(+)
diff --git a/drivers/phy/rockchip/phy-rockchip-emmc.c b/drivers/phy/rockchip/phy-rockchip-emmc.c index 48e2d75b1004..75faee5c0d27 100644 --- a/drivers/phy/rockchip/phy-rockchip-emmc.c +++ b/drivers/phy/rockchip/phy-rockchip-emmc.c @@ -253,6 +253,7 @@ static int rockchip_emmc_phy_init(struct phy *phy) */ rk_phy->emmcclk = clk_get(&phy->dev, "emmcclk"); if (IS_ERR(rk_phy->emmcclk)) { + ret = PTR_ERR(rk_phy->emmcclk); dev_dbg(&phy->dev, "Error getting emmcclk: %d\n", ret); rk_phy->emmcclk = NULL; } -- 2.20.1
| |