lkml.org 
[lkml]   [2020]   [Nov]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    Date
    SubjectRe: [PATCH 17/40] drm/amd/pm/powerplay/hwmgr/hardwaremanager: Fix function header related formatting issues
    On Thu, Nov 26, 2020 at 8:43 AM Lee Jones <lee.jones@linaro.org> wrote:
    >
    > Fixes the following W=1 kernel build warning(s):
    >
    > drivers/gpu/drm/amd/amdgpu/../pm/powerplay/hwmgr/hardwaremanager.c:232: warning: Function parameter or member 'hwmgr' not described in 'phm_start_thermal_controller'
    > drivers/gpu/drm/amd/amdgpu/../pm/powerplay/hwmgr/hardwaremanager.c:383: warning: Function parameter or member 'hwmgr' not described in 'phm_get_clock_info'
    > drivers/gpu/drm/amd/amdgpu/../pm/powerplay/hwmgr/hardwaremanager.c:383: warning: Function parameter or member 'state' not described in 'phm_get_clock_info'
    > drivers/gpu/drm/amd/amdgpu/../pm/powerplay/hwmgr/hardwaremanager.c:383: warning: Function parameter or member 'pclock_info' not described in 'phm_get_clock_info'
    > drivers/gpu/drm/amd/amdgpu/../pm/powerplay/hwmgr/hardwaremanager.c:383: warning: Function parameter or member 'designation' not described in 'phm_get_clock_info'
    >
    > Cc: Evan Quan <evan.quan@amd.com>
    > Cc: Alex Deucher <alexander.deucher@amd.com>
    > Cc: "Christian König" <christian.koenig@amd.com>
    > Cc: David Airlie <airlied@linux.ie>
    > Cc: Daniel Vetter <daniel@ffwll.ch>
    > Cc: amd-gfx@lists.freedesktop.org
    > Cc: dri-devel@lists.freedesktop.org
    > Signed-off-by: Lee Jones <lee.jones@linaro.org>

    Applied. Thanks!

    Alex

    > ---
    > .../amd/pm/powerplay/hwmgr/hardwaremanager.c | 25 ++++++++++---------
    > 1 file changed, 13 insertions(+), 12 deletions(-)
    >
    > diff --git a/drivers/gpu/drm/amd/pm/powerplay/hwmgr/hardwaremanager.c b/drivers/gpu/drm/amd/pm/powerplay/hwmgr/hardwaremanager.c
    > index 45dde3e74b578..25b5831a15cd2 100644
    > --- a/drivers/gpu/drm/amd/pm/powerplay/hwmgr/hardwaremanager.c
    > +++ b/drivers/gpu/drm/amd/pm/powerplay/hwmgr/hardwaremanager.c
    > @@ -223,11 +223,11 @@ int phm_register_irq_handlers(struct pp_hwmgr *hwmgr)
    > }
    >
    > /**
    > -* Initializes the thermal controller subsystem.
    > -*
    > -* @param pHwMgr the address of the powerplay hardware manager.
    > -* @exception PP_Result_Failed if any of the paramters is NULL, otherwise the return value from the dispatcher.
    > -*/
    > + * phm_start_thermal_controller - Initializes the thermal controller subsystem.
    > + *
    > + * @hwmgr: the address of the powerplay hardware manager.
    > + * Exception PP_Result_Failed if any of the paramters is NULL, otherwise the return value from the dispatcher.
    > + */
    > int phm_start_thermal_controller(struct pp_hwmgr *hwmgr)
    > {
    > int ret = 0;
    > @@ -371,13 +371,14 @@ int phm_get_performance_level(struct pp_hwmgr *hwmgr, const struct pp_hw_power_s
    >
    >
    > /**
    > -* Gets Clock Info.
    > -*
    > -* @param pHwMgr the address of the powerplay hardware manager.
    > -* @param pPowerState the address of the Power State structure.
    > -* @param pClockInfo the address of PP_ClockInfo structure where the result will be returned.
    > -* @exception PP_Result_Failed if any of the paramters is NULL, otherwise the return value from the back-end.
    > -*/
    > + * phm_get_clock_info
    > + *
    > + * @hwmgr: the address of the powerplay hardware manager.
    > + * @state: the address of the Power State structure.
    > + * @pclock_info: the address of PP_ClockInfo structure where the result will be returned.
    > + * @designation: PHM performance level designation
    > + * Exception PP_Result_Failed if any of the paramters is NULL, otherwise the return value from the back-end.
    > + */
    > int phm_get_clock_info(struct pp_hwmgr *hwmgr, const struct pp_hw_power_state *state, struct pp_clock_info *pclock_info,
    > PHM_PerformanceLevelDesignation designation)
    > {
    > --
    > 2.25.1
    >
    > _______________________________________________
    > dri-devel mailing list
    > dri-devel@lists.freedesktop.org
    > https://lists.freedesktop.org/mailman/listinfo/dri-devel

    \
     
     \ /
      Last update: 2020-12-01 00:42    [W:2.938 / U:0.028 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site