lkml.org 
[lkml]   [2020]   [Nov]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    Date
    SubjectRe: [PATCH 18/40] drm/amd/amdgpu/sdma_v3_0: Fix a bunch of kernel-doc function documentation issues
    On Tue, Nov 24, 2020 at 2:44 PM Lee Jones <lee.jones@linaro.org> wrote:
    >
    > Fixes the following W=1 kernel build warning(s):
    >
    > drivers/gpu/drm/amd/amdgpu/sdma_v3_0.c:428: warning: Function parameter or member 'job' not described in 'sdma_v3_0_ring_emit_ib'
    > drivers/gpu/drm/amd/amdgpu/sdma_v3_0.c:428: warning: Function parameter or member 'flags' not described in 'sdma_v3_0_ring_emit_ib'
    > drivers/gpu/drm/amd/amdgpu/sdma_v3_0.c:484: warning: Function parameter or member 'addr' not described in 'sdma_v3_0_ring_emit_fence'
    > drivers/gpu/drm/amd/amdgpu/sdma_v3_0.c:484: warning: Function parameter or member 'seq' not described in 'sdma_v3_0_ring_emit_fence'
    > drivers/gpu/drm/amd/amdgpu/sdma_v3_0.c:484: warning: Function parameter or member 'flags' not described in 'sdma_v3_0_ring_emit_fence'
    > drivers/gpu/drm/amd/amdgpu/sdma_v3_0.c:484: warning: Excess function parameter 'fence' description in 'sdma_v3_0_ring_emit_fence'
    > drivers/gpu/drm/amd/amdgpu/sdma_v3_0.c:870: warning: Function parameter or member 'timeout' not described in 'sdma_v3_0_ring_test_ib'
    > drivers/gpu/drm/amd/amdgpu/sdma_v3_0.c:1018: warning: Function parameter or member 'ring' not described in 'sdma_v3_0_ring_pad_ib'
    > drivers/gpu/drm/amd/amdgpu/sdma_v3_0.c:1070: warning: Function parameter or member 'vmid' not described in 'sdma_v3_0_ring_emit_vm_flush'
    > drivers/gpu/drm/amd/amdgpu/sdma_v3_0.c:1070: warning: Function parameter or member 'pd_addr' not described in 'sdma_v3_0_ring_emit_vm_flush'
    > drivers/gpu/drm/amd/amdgpu/sdma_v3_0.c:1070: warning: Excess function parameter 'vm' description in 'sdma_v3_0_ring_emit_vm_flush'
    > drivers/gpu/drm/amd/amdgpu/sdma_v3_0.c:1643: warning: Function parameter or member 'ib' not described in 'sdma_v3_0_emit_copy_buffer'
    > drivers/gpu/drm/amd/amdgpu/sdma_v3_0.c:1643: warning: Function parameter or member 'tmz' not described in 'sdma_v3_0_emit_copy_buffer'
    > drivers/gpu/drm/amd/amdgpu/sdma_v3_0.c:1643: warning: Excess function parameter 'ring' description in 'sdma_v3_0_emit_copy_buffer'
    > drivers/gpu/drm/amd/amdgpu/sdma_v3_0.c:1668: warning: Function parameter or member 'ib' not described in 'sdma_v3_0_emit_fill_buffer'
    > drivers/gpu/drm/amd/amdgpu/sdma_v3_0.c:1668: warning: Excess function parameter 'ring' description in 'sdma_v3_0_emit_fill_buffer'
    >
    > Cc: Alex Deucher <alexander.deucher@amd.com>
    > Cc: "Christian König" <christian.koenig@amd.com>
    > Cc: David Airlie <airlied@linux.ie>
    > Cc: Daniel Vetter <daniel@ffwll.ch>
    > Cc: Sumit Semwal <sumit.semwal@linaro.org>
    > Cc: amd-gfx@lists.freedesktop.org
    > Cc: dri-devel@lists.freedesktop.org
    > Cc: linux-media@vger.kernel.org
    > Cc: linaro-mm-sig@lists.linaro.org
    > Signed-off-by: Lee Jones <lee.jones@linaro.org>

    Applied with minor fixes. Thanks!

    Alex

    > ---
    > drivers/gpu/drm/amd/amdgpu/sdma_v3_0.c | 14 +++++++++++---
    > 1 file changed, 11 insertions(+), 3 deletions(-)
    >
    > diff --git a/drivers/gpu/drm/amd/amdgpu/sdma_v3_0.c b/drivers/gpu/drm/amd/amdgpu/sdma_v3_0.c
    > index c59f6f6f4c091..43410a7bccc25 100644
    > --- a/drivers/gpu/drm/amd/amdgpu/sdma_v3_0.c
    > +++ b/drivers/gpu/drm/amd/amdgpu/sdma_v3_0.c
    > @@ -417,7 +417,9 @@ static void sdma_v3_0_ring_insert_nop(struct amdgpu_ring *ring, uint32_t count)
    > * sdma_v3_0_ring_emit_ib - Schedule an IB on the DMA engine
    > *
    > * @ring: amdgpu ring pointer
    > + * @job: job to retrive vmid from
    > * @ib: IB object to schedule
    > + * @flags: unused
    > *
    > * Schedule an IB in the DMA ring (VI).
    > */
    > @@ -473,7 +475,9 @@ static void sdma_v3_0_ring_emit_hdp_flush(struct amdgpu_ring *ring)
    > * sdma_v3_0_ring_emit_fence - emit a fence on the DMA ring
    > *
    > * @ring: amdgpu ring pointer
    > - * @fence: amdgpu fence object
    > + * @addr: address
    > + * @seq: sequence number
    > + * @flags: fence related flags
    > *
    > * Add a DMA fence packet to the ring to write
    > * the fence seq number and DMA trap packet to generate
    > @@ -862,6 +866,7 @@ static int sdma_v3_0_ring_test_ring(struct amdgpu_ring *ring)
    > * sdma_v3_0_ring_test_ib - test an IB on the DMA engine
    > *
    > * @ring: amdgpu_ring structure holding ring information
    > + * @timeout: timeout value in jiffies, or MAX_SCHEDULE_TIMEOUT
    > *
    > * Test a simple IB in the DMA ring (VI).
    > * Returns 0 on success, error on failure.
    > @@ -1011,6 +1016,7 @@ static void sdma_v3_0_vm_set_pte_pde(struct amdgpu_ib *ib, uint64_t pe,
    > /**
    > * sdma_v3_0_ring_pad_ib - pad the IB to the required number of dw
    > *
    > + * @ring: amdgpu_ring structure holding ring information
    > * @ib: indirect buffer to fill with padding
    > *
    > */
    > @@ -1060,7 +1066,8 @@ static void sdma_v3_0_ring_emit_pipeline_sync(struct amdgpu_ring *ring)
    > * sdma_v3_0_ring_emit_vm_flush - cik vm flush using sDMA
    > *
    > * @ring: amdgpu_ring pointer
    > - * @vm: amdgpu_vm pointer
    > + * @vmid: vmid number to use
    > + * @pd_addr: address
    > *
    > * Update the page table base and flush the VM TLB
    > * using sDMA (VI).
    > @@ -1630,6 +1637,7 @@ static void sdma_v3_0_set_irq_funcs(struct amdgpu_device *adev)
    > * @src_offset: src GPU address
    > * @dst_offset: dst GPU address
    > * @byte_count: number of bytes to xfer
    > + * @tmz: unused
    > *
    > * Copy GPU buffers using the DMA engine (VI).
    > * Used by the amdgpu ttm implementation to move pages if
    > @@ -1654,7 +1662,7 @@ static void sdma_v3_0_emit_copy_buffer(struct amdgpu_ib *ib,
    > /**
    > * sdma_v3_0_emit_fill_buffer - fill buffer using the sDMA engine
    > *
    > - * @ring: amdgpu_ring structure holding ring information
    > + * @ib: indirect buffer to copy to
    > * @src_data: value to write to buffer
    > * @dst_offset: dst GPU address
    > * @byte_count: number of bytes to xfer
    > --
    > 2.25.1
    >
    > _______________________________________________
    > dri-devel mailing list
    > dri-devel@lists.freedesktop.org
    > https://lists.freedesktop.org/mailman/listinfo/dri-devel

    \
     
     \ /
      Last update: 2020-11-30 23:28    [W:3.103 / U:0.008 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site