Messages in this thread |  | | Date | Tue, 3 Nov 2020 15:22:16 -0800 | | From | Jakub Kicinski <> | | Subject | Re: [PATCH net-next v7 0/5] net: hdlc_fr: Improve fr_rx and add support for any Ethertype |
| |
On Sat, 31 Oct 2020 11:10:38 -0700 Xie He wrote: > The main purpose of this series is the last patch. The previous 4 patches > are just code clean-ups so that the last patch will not make the code too > messy. The patches must be applied in sequence. > > The receiving code of this driver doesn't support arbitrary Ethertype > values. It only recognizes a few known Ethertypes when receiving and drops > skbs with other Ethertypes. > > However, the standard document RFC 2427 allows Frame Relay to support any > Ethertype values. This series adds support for this.
Applied, but going forward please limit any refactoring and extensions to the HDLC code. I thought you are actually using it. If that's not the case let's leave the code be, it's likely going to be removed in a few years time.
|  |