Messages in this thread | | | From | Khalil Blaiech <> | Subject | RE: [PATCH] i2c: mlxbf: Fix build error with CONFIG_ACPI disabled | Date | Tue, 3 Nov 2020 22:22:54 +0000 |
| |
Liu, thank you very much for the fix.
Please note that I posted a patch series on October, 28th including this fix. Also note that I posted a v2 today.
Khalil
> Subject: [PATCH] i2c: mlxbf: Fix build error with CONFIG_ACPI disabled > > drivers/i2c/busses/i2c-mlxbf.c: In function ‘mlxbf_i2c_acpi_probe’: > drivers/i2c/busses/i2c-mlxbf.c:2296:8: error: implicit declaration of function > ‘acpi_device_uid’; did you mean ‘cpu_device_up’? [-Werror=implicit- > function-declaration] > uid = acpi_device_uid(adev); > ^~~~~~~~~~~~~~~ > cpu_device_up > > Signed-off-by: Liu Shixin <liushixin2@huawei.com> > --- > drivers/i2c/busses/i2c-mlxbf.c | 7 +++++++ > 1 file changed, 7 insertions(+) > > diff --git a/drivers/i2c/busses/i2c-mlxbf.c b/drivers/i2c/busses/i2c-mlxbf.c > index ee59e0da082d..cd8a909431a9 100644 > --- a/drivers/i2c/busses/i2c-mlxbf.c > +++ b/drivers/i2c/busses/i2c-mlxbf.c > @@ -2272,6 +2272,7 @@ static const struct acpi_device_id > mlxbf_i2c_acpi_ids[] = { > > MODULE_DEVICE_TABLE(acpi, mlxbf_i2c_acpi_ids); > > +#ifdef CONFIG_ACPI > static int mlxbf_i2c_acpi_probe(struct device *dev, struct mlxbf_i2c_priv > *priv) > { > const struct acpi_device_id *aid; > @@ -2305,6 +2306,12 @@ static int mlxbf_i2c_acpi_probe(struct device > *dev, struct mlxbf_i2c_priv *priv) > > return ret; > } > +#else > +static int mlxbf_i2c_acpi_probe(struct device *dev, struct mlxbf_i2c_priv > *priv) > +{ > + return -ENODEV; > +} > +#endif > > static int mlxbf_i2c_of_probe(struct device *dev, struct mlxbf_i2c_priv > *priv) > { > -- > 2.25.1
| |