lkml.org 
[lkml]   [2020]   [Nov]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRE: [PATCH] i2c: mlxbf: Fix build error with CONFIG_ACPI disabled
Date
Liu, thank you very much for the fix.

Please note that I posted a patch series on October, 28th including
this fix. Also note that I posted a v2 today.

Khalil

> Subject: [PATCH] i2c: mlxbf: Fix build error with CONFIG_ACPI disabled
>
> drivers/i2c/busses/i2c-mlxbf.c: In function ‘mlxbf_i2c_acpi_probe’:
> drivers/i2c/busses/i2c-mlxbf.c:2296:8: error: implicit declaration of function
> ‘acpi_device_uid’; did you mean ‘cpu_device_up’? [-Werror=implicit-
> function-declaration]
> uid = acpi_device_uid(adev);
> ^~~~~~~~~~~~~~~
> cpu_device_up
>
> Signed-off-by: Liu Shixin <liushixin2@huawei.com>
> ---
> drivers/i2c/busses/i2c-mlxbf.c | 7 +++++++
> 1 file changed, 7 insertions(+)
>
> diff --git a/drivers/i2c/busses/i2c-mlxbf.c b/drivers/i2c/busses/i2c-mlxbf.c
> index ee59e0da082d..cd8a909431a9 100644
> --- a/drivers/i2c/busses/i2c-mlxbf.c
> +++ b/drivers/i2c/busses/i2c-mlxbf.c
> @@ -2272,6 +2272,7 @@ static const struct acpi_device_id
> mlxbf_i2c_acpi_ids[] = {
>
> MODULE_DEVICE_TABLE(acpi, mlxbf_i2c_acpi_ids);
>
> +#ifdef CONFIG_ACPI
> static int mlxbf_i2c_acpi_probe(struct device *dev, struct mlxbf_i2c_priv
> *priv)
> {
> const struct acpi_device_id *aid;
> @@ -2305,6 +2306,12 @@ static int mlxbf_i2c_acpi_probe(struct device
> *dev, struct mlxbf_i2c_priv *priv)
>
> return ret;
> }
> +#else
> +static int mlxbf_i2c_acpi_probe(struct device *dev, struct mlxbf_i2c_priv
> *priv)
> +{
> + return -ENODEV;
> +}
> +#endif
>
> static int mlxbf_i2c_of_probe(struct device *dev, struct mlxbf_i2c_priv
> *priv)
> {
> --
> 2.25.1

\
 
 \ /
  Last update: 2020-11-03 23:24    [W:0.042 / U:0.696 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site