lkml.org 
[lkml]   [2020]   [Nov]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.4 069/214] ACPI: HMAT: Fix handling of changes from ACPI 6.2 to ACPI 6.3
    Date
    From: Jonathan Cameron <Jonathan.Cameron@huawei.com>

    [ Upstream commit 2c5b9bde95c96942f2873cea6ef383c02800e4a8 ]

    In ACPI 6.3, the Memory Proximity Domain Attributes Structure
    changed substantially. One of those changes was that the flag
    for "Memory Proximity Domain field is valid" was deprecated.

    This was because the field "Proximity Domain for the Memory"
    became a required field and hence having a validity flag makes
    no sense.

    So the correct logic is to always assume the field is there.
    Current code assumes it never is.

    Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
    Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/acpi/hmat/hmat.c | 3 ++-
    1 file changed, 2 insertions(+), 1 deletion(-)

    diff --git a/drivers/acpi/hmat/hmat.c b/drivers/acpi/hmat/hmat.c
    index 8b0de8a3c6470..0f1c939b7e901 100644
    --- a/drivers/acpi/hmat/hmat.c
    +++ b/drivers/acpi/hmat/hmat.c
    @@ -403,7 +403,8 @@ static int __init hmat_parse_proximity_domain(union acpi_subtable_headers *heade
    pr_info("HMAT: Memory Flags:%04x Processor Domain:%d Memory Domain:%d\n",
    p->flags, p->processor_PD, p->memory_PD);

    - if (p->flags & ACPI_HMAT_MEMORY_PD_VALID && hmat_revision == 1) {
    + if ((hmat_revision == 1 && p->flags & ACPI_HMAT_MEMORY_PD_VALID) ||
    + hmat_revision > 1) {
    target = find_mem_target(p->memory_PD);
    if (!target) {
    pr_debug("HMAT: Memory Domain missing from SRAT\n");
    --
    2.27.0


    \
     
     \ /
      Last update: 2020-11-03 22:43    [W:4.081 / U:0.212 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site