Messages in this thread | | | Date | Fri, 27 Nov 2020 17:56:42 -0800 | From | Jakub Kicinski <> | Subject | Re: [PATCH] powerpc: fix the allyesconfig build |
| |
On Sat, 28 Nov 2020 12:28:19 +1100 Stephen Rothwell wrote: > There are 2 drivers that have arrays of packed structures that contain > pointers that end up at unaligned offsets. These produce warnings in > the PowerPC allyesconfig build like this: > > WARNING: 148 bad relocations > c00000000e56510b R_PPC64_UADDR64 .rodata+0x0000000001c72378 > c00000000e565126 R_PPC64_UADDR64 .rodata+0x0000000001c723c0 > > They are not drivers that are used on PowerPC (I assume), so mark them > to not be built on PPC64 when CONFIG_RELOCATABLE is enabled.
😳😳
What's the offending structure in hisilicon? I'd rather have a look packing structs with pointers in 'em sounds questionable.
I only see these two:
$ git grep packed drivers/net/ethernet/hisilicon/ drivers/net/ethernet/hisilicon/hns/hnae.h:struct __packed hnae_desc { drivers/net/ethernet/hisilicon/hns3/hns3_enet.h:struct __packed hns3_desc {
| |